Skip to content

Untransform workspace/applyEdit so edits reach the client as notebook edits #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasjm merged 2 commits into from
Oct 15, 2026
Merged

Untransform workspace/applyEdit so edits reach the client as notebook edits #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f12414
Untransform workspace/applyEdit so edits reach the client as notebook…
thomasjm Oct 15, 2026
62ce901
Point at core's merged commit
thomasjm Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ readWrappedOut config clientReqMap serverReqMap wrappedOut sendToStdout = foreve
modifyMVar_ serverReqMap $ \m -> case updateServerRequestMap m msgId (SMethodAndParams meth (msg ^. Lens.params)) of
Just m' -> return m'
Nothing -> return m
sendToStdout (transformServerReq meth msg)
transformServerReq meth msg >>= sendToStdout
Right (ServerToClientRsp meth initialParams msg) ->
transformServerRsp config meth initialParams msg >>= sendToStdout

Expand Down
1 change: 1 addition & 0 deletions src/Transform/Config.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ rustNotebookConfig :: FilePath -> Int -> NotebookConfig RustNotebookTransformer
rustNotebookConfig shadowDir didSaveDebounceMs = NotebookConfig {
notebookConfigHandles = const True
, notebookConfigDidSaveDebounceMs = Just didSaveDebounceMs
, notebookConfigHandlesFormatting = True
, notebookConfigTransformerParamsFor = \u -> if isNotebook u then transformerParams else idTransformerParams
, notebookConfigMakeShadowDocument = makeShadowDocument shadowDir
, notebookConfigUnopenedUri = addExtensionToUri ".rs"
Expand Down
2 changes: 1 addition & 1 deletion stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ system-ghc: true

extra-deps:
- git: https://github.com/codedownio/notebook-language-server-core.git
commit: cb55077c20b22919956d0fcfa4287c5cb82c8fa2
commit: 244731900dee065cbf794ba74294f3a0f55c74fd

# - language-rust-0.2.0.27

Expand Down
8 changes: 4 additions & 4 deletions stack.yaml.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@

packages:
- completed:
commit: cb55077c20b22919956d0fcfa4287c5cb82c8fa2
commit: 244731900dee065cbf794ba74294f3a0f55c74fd
git: https://github.com/codedownio/notebook-language-server-core.git
name: notebook-language-server-core
pantry-tree:
sha256: 9ba9d7a2e117c3fe1d0767d4b5992007bb69d7bdfbb306c133b762e73a79c082
size: 2202
sha256: 53abc5c9405647f56c1bd03ca3f1f29d0b9c5c7745ed39a89c7946aaced27f00
size: 2399
version: 0.1.0.0
original:
commit: cb55077c20b22919956d0fcfa4287c5cb82c8fa2
commit: 244731900dee065cbf794ba74294f3a0f55c74fd
git: https://github.com/codedownio/notebook-language-server-core.git
snapshots:
- completed:
Expand Down
Loading