Repository navigation
Show what a conference still has to resolve - #2305
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
what it looks like (with lorem ipsum copy) |
The conference page gains the mockup's "What needs to be resolved?" section between Committee and Public Input, with an Unresolved Text tab: a one-sentence gist with a feedback link, the differences as disclosures with a Senate and a House card each (the first open, "Not in the bill" where a chamber's text is left out, noted terms as tooltips), the matching points beside them where there is room, a line naming the reader's own legislator, and the sources as numbered marks with a list at the foot of the card. A conference with nothing written has no section and no tab. The conference YAML gains a gist, chamber texts that may be left out, and term notes; the page loader now passes gist, differences and similarities through. Phone-Free Schools carries lorem ipsum until the real copy is written. The tab row's height is one constant shared by the pinned heading and every section's scroll margin, and the feedback form address moves to components/common. Closes #70 Verified: jest components/conference 41/41 (in the next container); tsc and eslint; test:integration-ci tests/integration/conferences.test.ts 11/11. In Chrome beside the mockup at 19bd101, desktop and a 390px iframe: heading, labels, chamber cards, answer and match text, gist, term tooltip and the pinned heading match by computed style. Not verified: the your-legislator line in the browser (jest only, no signed-in profile); the copy itself, which is lorem ipsum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fastfadingviolets
force-pushed
the
conference-differences
branch
from
October 21, 2026 20:04
61e64b9 to
f3bf6d8
Compare
Mephistic
approved these changes
Oct 25, 2026
fastfadingviolets
marked this pull request as ready for review
October 26, 2026 20:12
fastfadingviolets
requested review from
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
October 26, 2026 20:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conference page gains a "What needs to be resolved?" section, between Committee and Public Input: the House and Senate differences as disclosures with a card per chamber, the points where the texts already match, a one-sentence gist, the reader's own legislator if they sit on the committee, and numbered sources. It is authored in the conference YAML, never generated, and Phone-Free Schools carries lorem ipsum until the real copy is written. The branch is stacked on conference-testimony and targets main, so it should be merged after #2303 is merged
Closes hyphacoop#70
What's in it
🤖 Generated with Claude Code