Skip to content

feat(modal): add "full" size option #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ubf-hunter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(modal): add "full" size option #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Modal/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { overwriteReadonlyProp } from "tsafe/lab/overwriteReadonlyProp";
export type ModalProps = {
className?: string;
/** Default: "medium" */
size?: "small" | "medium" | "large";
size?: "small" | "medium" | "large" | "full";
title: ReactNode;
titleAs?: "h1" | "h2" | "h3" | "h4" | "h5" | "h6" | "p" | "div";
titleProps?: React.DetailedHTMLProps<
Expand Down Expand Up @@ -81,6 +81,8 @@ const Modal = memo(
<div
className={(() => {
switch (size) {
case "full":
return fr.cx("fr-col-12", "fr-col-md-12", "fr-col-lg-12");
case "large":
return fr.cx("fr-col-12", "fr-col-md-10", "fr-col-lg-8");
case "small":
Expand Down
2 changes: 1 addition & 1 deletion stories/Modal.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ To create a Dialog component, something that you would use to ask the user a que
},
"size": {
"options": (() => {
const options = ["small", "medium", "large"] as const;
const options = ["small", "medium", "large", "full"] as const;

assert<Equals<typeof options[number] | undefined, ModalProps["size"]>>();

Expand Down