Skip to content

fix(Pagination): add accessible labels to page links #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daikozi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Pagination): add accessible labels to page links #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const Pagination = memo(
<Link
className={cx(fr.cx("fr-pagination__link"), classes.link)}
aria-current={part.active ? true : undefined}
title={`Page ${part.number}`}
aria-label={t("page", { pageNumber: part.number })}
{...getPageLinkProps(part.number)}
>
{part.number}
Expand Down Expand Up @@ -223,6 +223,7 @@ const { useTranslation, addPaginationTranslations } = createComponentI18nApi({
"frMessages": {
"first page": "Première page",
"previous page": "Page précédente",
"page": ({ pageNumber }: { pageNumber: number }) => `Page ${pageNumber}`,
"next page": "Page suivante",
"last page": "Dernière page",
"aria-label": "Pagination"
Expand All @@ -234,6 +235,7 @@ addPaginationTranslations({
"messages": {
"first page": "First page",
"previous page": "Previous page",
"page": ({ pageNumber }: { pageNumber: number }) => `Page ${pageNumber}`,
"next page": "Next page",
"last page": "Last page",
"aria-label": "Pagination"
Expand Down