fix: detect Safari version from Version token#10251
Open
memleakd wants to merge 1 commit into
Open
Conversation
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
patel-vansh
approved these changes
May 30, 2026
michalsn
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Safari version detection in the
UserAgentparser. Safari user agents commonly include both aVersion/...token and aSafari/...token:The
Safari/...token is not the user-facing Safari browser version. The actual browser version is reported byVersion/....Previously, CodeIgniter identified the browser as Safari but returned the
Safari/...value as the version. That could make browser-version checks behave incorrectly, e.g. treating Safari16.3as newer than16.4because it was reported as605.1.15.This keeps Safari detection unchanged, but when Safari is matched it uses the
Version/...token forgetVersion()if present.Tests cover desktop Safari, mobile Safari, and Chrome user agents that also contain a
Safari/...token.Fixes #10250
Checklist: