Skip to content

fix: resolve TypeError in CLIRequest::parseCommand when argv is missing #10415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gr8man wants to merge 5 commits into
base: develop
Choose a base branch
from
+13 −1
Open

fix: resolve TypeError in CLIRequest::parseCommand when argv is missing #10415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b86b0a
Fix CLIRequest parseCommand TypeError when argv is missing
gr8man Jul 18, 2026
5ea0798
docs: add changelog for CLIRequest parseCommand TypeError fix
gr8man Jul 19, 2026
dcc7e7d
trigger CI
gr8man Jul 19, 2026
4d247bc
trigger CI
gr8man Jul 19, 2026
e5dca4e
Merge branch 'develop' into fix/cli-request-argv
gr8man Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/HTTP/CLIRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public function getOptionString(bool $useLongOpts = false): string
*/
protected function parseCommand()
{
$args = $this->getServer('argv');
$args = $this->getServer('argv') ?? [];
array_shift($args); // Scrap index.php

$optionValue = false;
Expand Down
11 changes: 11 additions & 0 deletions tests/system/HTTP/CLIRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,4 +574,15 @@ public function testIs(): void
{
$this->assertFalse($this->request->is('get'));
}

public function testParseCommandWithMissingArgv(): void
{
Services::injectMock('superglobals', new Superglobals([], [], [], [], []));

$request = new CLIRequest(new App());

$this->assertSame('', $request->getPath());
$this->assertSame([], $request->getSegments());
$this->assertSame('', $request->getOptionString());
}
}
1 change: 1 addition & 0 deletions user_guide_src/source/changelogs/v4.7.5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Deprecations
Bugs Fixed
**********

- **CLIRequest:** Fixed a bug where ``parseCommand()`` could throw a TypeError when ``argv`` is missing.
- **Content Security Policy:** Fixed a bug where empty ``Content-Security-Policy``, ``Content-Security-Policy-Report-Only``, and ``Reporting-Endpoints`` response headers were generated when no corresponding values existed.
- **Logger:** Fixed a bug where interpolating a log message with array or non-stringable context values could raise PHP warnings or errors.

Expand Down
Loading