Skip to content

fix(HTTP): remove invalid CURLOPT_HTTPHEADER string assignment in CURLRequest - #10695

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
gr8man:fix/curlrequest-decode-content-httpheader
Nov 1, 2026
Merged

paulbalandan merged 1 commit into
codeigniter4:developfrom
gr8man:fix/curlrequest-decode-content-httpheader

Conversation

@gr8man

@gr8man gr8man commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Description
Fixes a TypeError in CURLRequest when decode_content was enabled on requests without custom headers, caused by assigning the string 'Accept-Encoding' to CURLOPT_HTTPHEADER instead of an array. Setting CURLOPT_ENCODING to an empty string is sufficient for libcurl to request and decode supported encodings.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 31, 2026
@paulbalandan paulbalandan changed the title fix(HTTP): remove invalid CURLOPT_HTTPHEADER string assignment in CURLRequest fix(HTTP): remove invalid CURLOPT_HTTPHEADER string assignment in CURLRequest Nov 1, 2026

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paulbalandan
paulbalandan merged commit 2ce90cf into codeigniter4:develop Nov 1, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants