Repository navigation
Conversation
Send HMSET and EXPIREAT together in a single pipeline round trip rather than issuing two sequential network requests on every cache save. For normal cache usage, behavior and data structures remain identical. In error scenarios where HMSET fails (e.g. key contains a non-hash type), the pipelined EXPIREAT will still execute on the existing key, while save() returns false as expected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In both
RedisHandler::save()andPredisHandler::save(), saving a cache item with a TTL previously executed two sequential network round trips:hMset(hmset)expireAt(expireat)This PR executes both commands in a single network round trip using Redis pipelining (
$this->redis->multi(Redis::PIPELINE)inRedisHandlerand$this->redis->pipeline(...)inPredisHandler).Behavior & Compatibility Analysis
['__ci_type' => ..., '__ci_value' => ...]). This ensures 100% compatibility with existing cache keys,hMget(),hIncrBy()(increment()/decrement()), andgetMetaData().hMsetwithout expiration.HMSETfails (e.g. if an existing key holds a non-hash data type),EXPIREATin the pipeline batch will still execute on that existing key, whilesave()returnsfalseas expected (previouslyexpireAtwas not reached ifhMsetfailed). Using a Lua script to conditionally expire was considered, but avoided to prevent cluster and proxy portability complexity.Benchmark (5,000 save() operations, local loopback)
Checklist: