chore(phpstan): restrict unsealed credential keys to string keys#1332
Open
datamweb wants to merge 1 commit into
Open
chore(phpstan): restrict unsealed credential keys to string keys#1332datamweb wants to merge 1 commit into
datamweb wants to merge 1 commit into
Conversation
5 tasks
paulbalandan
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up on the previous change(PR #1330 ) that introduced PHPStan unsealed array shapes for authenticator credentials.
In the earlier PR, bare
...was used in array shapes. However, in PHPStan this expands to...<array-key, mixed>, which allows bothstringandintkeys. That is broader than intended for Shield credentials, because custom login fields are expected to bestring-keyedfields.Checklist: