Repository navigation
Harden upload handling and storage quota checks - #243
Merged
Merged
Conversation
- Run ffmpeg without a shell and restrict file extensions to [A-Za-z0-9]{1,10}
- Keep MCP upload temp files at a server-chosen path
- Count unsealed uploads toward storage and re-check the limit on seal
- Add regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[A-Za-z0-9]{1,10}(REST, tus and MCP uploads)upload_mediatemp files to a server-chosen path instead of one built from the caller's file nameTesting
src/media/utils/__tests__,src/mcp/tools/__tests__/upload.test.ts,src/media/__tests__/quota.test.tstsccleanNote: the dashboard storage figure now includes unsealed uploads.