Repository navigation
Brand the hosted login and app picker pages - #248
Merged
Merged
Conversation
The login page is served by oauth-server-kit from the API host, but MediaLit passed only the app name, so it showed the kit's default brown button, a black M placeholder and no favicon. Pass the web app's icon as the logo and favicon and use the medialit product color (oklch(0.6 0.14 300)) for the login page. The app picker takes the same brand so the flow stays consistent. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted login page is served by oauth-server-kit from the API host. MediaLit passed only the app name, so the page showed the kit's default brown button, a black M placeholder and no favicon.
Changes:
app.ts: pass the web app's/icon.svgas logo and favicon, andoklch(0.6 0.14 300)(the medialit product token) as the primary color, to the login router and the app picker.oauth-app-pages.ts: the app picker takes the same brand instead of the hardcoded brown and the M placeholder.Verified: API typecheck, full API test suite (165/165), prettier and eslint on changed files, and the kit's login HTML renders the icon and favicon.