Repository navigation
fix(security): close the five high-severity audit findings - #179
Merged
Merged
Conversation
- CSRF: cookie-session writes on the REST API now require the dashboard origin and the double-submit CSRF token; the dashboard proxy checks the origin and attaches the token itself. - OAuth tokens issued for the MCP resource no longer authenticate REST. - MCP ESP and Postmaster/SNDS tools enforce the same team-admin rule as REST (shared in team/authority.ts). - The dashboard /api/proxy sandboxes every response (CSP + nosniff) so tenant HTML cannot run on the dashboard origin. - Removing or demoting an organization member revokes their team access and the team API keys they created. Docs for authentication and MCP updated. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
QA smoke test on
🤖 Generated with Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the five high-severity findings from the second security-audit run against main (620f98f).
Docs (authentication, MCP) updated. Each fix has a regression test.
Behaviour to confirm
Demoting an org admin to member also removes access to teams they were explicitly added to.
Test plan
🤖 Generated with Claude Code