Repository navigation
fix(web): editor's unsaved-changes dialog - #180
Merged
Merged
Conversation
…email The 'Send test' dialog saves the document through the editor's actions prop, which called onSave directly. That left the unsaved-changes flag set, so leaving the editor showed 'Save your changes?' for an email that was already saved. Every save now goes through one persist helper that clears the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The three actions need about 414px, but a confirmation dialog is 384px wide, so the button row and the text pushed past the card's right edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the "Save your changes?" dialog in the full-screen email editor.
actionsprop, which calledonSavedirectly and left the unsaved-changes flag set. Leaving then asked to save an email that was already saved. All saves now go through onepersisthelper that clears the flag (and sets it again if the save fails).data-[size=default]:sm:max-w-lg. The sharedalert-dialog.tsxis unchanged.Tests: a new case for each (save via action then exit shows no dialog; the dialog has the wider class). Checked the width by rendering the markup with the compiled Tailwind CSS, not in the live editor.
🤖 Generated with Claude Code