fix: Return empty results when BM25 keyword index is empty - #73
Open
VedantMadane wants to merge 1 commit into
Open
fix: Return empty results when BM25 keyword index is empty#73VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
- Skip BM25Okapi([]) construction which ZeroDivisionErrors in IDF - search() already returned [] for empty chunks; index() now matches - Remove xfail on test_empty_index (issue codepath#68 / H-01) Fixes codepath#68 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return empty results when BM25 keyword index is empty
Changes
ZeroDivisionErrorwhen the index is empty #68 / H-01)Fixes #68