Fix resume section detection on text with leading whitespace - #74
Open
deepusnath wants to merge 1 commit into
Open
Fix resume section detection on text with leading whitespace#74deepusnath wants to merge 1 commit into
deepusnath wants to merge 1 commit into
Conversation
_detect_sections() and _strip_markdown() anchored their regexes to the exact start of a line, so section headers and markdown headers indented with leading spaces/tabs (common in PDF-extracted text and in-code fixtures) were never matched. Allow optional leading whitespace before the anchored patterns. Fixes codepath#54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_detect_sections() and _strip_markdown() anchored their regexes to the exact start of a line, so section headers and markdown headers indented with leading spaces/tabs (common in PDF-extracted text and in-code fixtures) were never matched. Allow optional leading whitespace before the anchored patterns.
Fixes #54
Summary
Issue
Closes #
Changes
Testing
make test-unit)make test-integration)make lint)make typecheck)@pytest.mark.xfailmarker (and anymatching suppression in
pyproject.toml)Screenshots / Demo
Notes for Reviewers