Repository navigation
ci: give the macOS quality gates 45 minutes instead of 30 - #306
Merged
Merged
Conversation
A passing quality-gates-macos run takes 18 to 28 minutes, mostly 26 to 28, so the 30-minute limit left 2 to 4 minutes for a slow runner. On a slow runner the job hit the limit while its integration tests were still passing, and the merge queue then dropped the PR (failed_checks) although every Linux job had passed. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Nov 3, 2026
dannyward630
pushed a commit
to dannyward630/agent-tty
that referenced
this pull request
Nov 4, 2026
As one serial job, quality-gates-macos took 18 to 30 minutes, and the integration tests were 75 to 80 percent of it (1251 s of 27 min in the coder#306 run). The suite grows by about 3 minutes a day, so the 45-minute limit would last about a week. The macOS tests now run in four jobs at once: checks-macos (format, lint, typecheck, build, unit and e2e tests) and test-integration-macos (1/3, 2/3, 3/3), each with a 30-minute limit. quality-gates-macos stays as the check that the main ruleset requires. It now runs on Ubuntu, needs those jobs, and fails when any of them failed, was cancelled or was skipped, the same way quality-gates gates the Linux jobs. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The operator's goal for this run is to land every follow-up fix. The
quality-gates-macosjob now blocks that: it hits its 30-minute limit on a slow runner, and the merge queue then drops the PR although every Linux job passed. This happened to #298 twice.What changed
.github/workflows/ci.yml:quality-gates-macosgetstimeout-minutes: 45instead of30, with one comment line that gives the reason. No other job changes.Evidence
quality-gates-macosjob took 18 to 28 minutes (17 runs), and mostly 26 to 28 minutes. The 30-minute limit left 2 to 4 minutes for a slow runner.quality-gates-macoswas cancelled after 30 minutes. All other jobs passed. The queue removed docs: say that a query a shell command prints leaves its reply at the next prompt #298 withfailed_checks.Test integrationstill passing tests at 21:33 (screen-hash.test.ts), 26 minutes into the step. The runner was slow, and no test hung.Test e2e. Attempt 2 passed in 27 minutes.Test integration.Validation
actionlint: pass.zizmor --offline .: no findings.npx oxfmt .github/workflows/ci.yml --check: pass.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:xhigh