Conversation
Workspace log archives previously lacked Coder deployment and workspace diagnostics, so troubleshooting connection issues required collecting a separate support bundle. In this change, we added a Coder support bundle to the Toolbox ZIP generated by an environment's Collect logs action. The plugin uses the existing deployment login to collect diagnostics for the selected workspace and its agent, when available. Collection supports cancellation and has a two-minute timeout. If it fails, the plugin preserves the other Toolbox diagnostics and adds a failure report instead of a partial bundle. We also documented where bundle collection is available and added tests for collection, cancellation, timeout, and cleanup.
code-asher
approved these changes
Sep 17, 2026
Comment on lines
+614
to
+616
| // An inherited token must not override the selected deployment's stored login. | ||
| builder.environment().remove("CODER_SESSION_TOKEN") | ||
| builder.environment().remove("CODER_HEADER_COMMAND") |
Member
There was a problem hiding this comment.
Is this something we should be doing for the other cli invocations as well? Or is there something unique about this one?
| /** Runs the support-bundle command with a timeout and terminates it on cancellation. */ | ||
| internal suspend fun runSupportBundleProcess( | ||
| command: List<String>, | ||
| timeoutSeconds: Long = 120, |
Member
There was a problem hiding this comment.
Two minutes does seem like a very long time but at the same time I feel like it will just take however long it takes, and the user can cancel if they feel like it takes too long, rather than trying to be prescriptive about it.
Any harm in letting it be unbounded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace log archives previously lacked Coder deployment and workspace diagnostics, so troubleshooting connection issues required collecting a separate support bundle.
In this change, we added a Coder support bundle to the Toolbox ZIP generated by an environment's Collect logs action. The plugin uses the existing deployment login to collect diagnostics for the selected workspace and its agent, when available.
Collection supports cancellation and has a two-minute timeout. If it fails, the plugin preserves the other Toolbox diagnostics and adds a failure report instead of a partial bundle.
We also documented where bundle collection is available and added tests for collection, cancellation, timeout, and cleanup.