Skip to content

Ignore schedule conflict warnings for cumulative time-limit rounds#81

Merged
coder13 merged 1 commit into
mainfrom
codex/fix-overlapping-assignment-warnings
May 14, 2026
Merged

Ignore schedule conflict warnings for cumulative time-limit rounds#81
coder13 merged 1 commit into
mainfrom
codex/fix-overlapping-assignment-warnings

Conversation

@coder13
Copy link
Copy Markdown
Owner

@coder13 coder13 commented May 14, 2026

Motivation

  • Prevent false-positive schedule conflict warnings when two different events' rounds share a cumulative time limit and therefore are expected to run concurrently.

Description

  • Added roundsShareCumulativeTimeLimit helper in src/lib/wcif/validation/personAssignmentValidation.ts to detect when two activities belong to rounds that mutually list each other in timeLimit.cumulativeRoundIds.
  • Skip reporting overlaps in findConflictingAssignmentsForPerson when roundsShareCumulativeTimeLimit returns true so assignments in such cumulative rounds do not generate conflicts.
  • Added a regression test in src/lib/wcif/validation/personAssignmentValidation.test.ts that sets up two events/rounds (e.g., 4BLD/5BLD) with matching cumulativeRoundIds and overlapping times and asserts no conflict is produced.

Testing

  • Ran npm run test -- src/lib/wcif/validation/personAssignmentValidation.test.ts in this environment and it failed to execute because the vitest binary was not found in PATH (sh: 1: vitest: not found).
  • No other automated test runs were performed in this environment, but a focused unit test covering the new behavior was added to personAssignmentValidation.test.ts.

Codex Task

@coder13 coder13 merged commit f31263f into main May 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant