Harden Cursor CLI workflows#2
Draft
nehal-a2z wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
review_completedfromreview_skipped, and expose--lightreview --agentown authenticationRoot cause
The plugin duplicated parts of the CLI contract in prose and in a post-tool hook. The hook classified command text and human-readable output rather than authoritative terminal NDJSON events, while the validator only checked that hook files existed. The autofix workflow also treated warnings as sufficient state checks and did not bind later writes to an immutable PR, commit, and destination.
User impact
Validation
node --check scripts/validate-plugin.mjsnode scripts/validate-plugin.mjsgit diff --checkThe focused plugin validator passes. No dependency install or broad build/lint/test loop was run.