perf(paymaster): batch subscription check over workspaces#550
Open
perf(paymaster): batch subscription check over workspaces#550
Conversation
neSpecc
reviewed
May 6, 2026
neSpecc
previously approved these changes
May 6, 2026
e11sy
previously approved these changes
May 6, 2026
Comment on lines
+240
to
+243
| const current = batch; | ||
|
|
||
| batch = []; | ||
| await Promise.all(current.map((workspace) => this.processWorkspaceSubscriptionCheck(workspace))); |
Member
There was a problem hiding this comment.
Suggested change
| const current = batch; | |
| batch = []; | |
| await Promise.all(current.map((workspace) => this.processWorkspaceSubscriptionCheck(workspace))); | |
| await Promise.all(batch.map((workspace) => this.processWorkspaceSubscriptionCheck(workspace))); | |
| batch = []; |
| .filter(workspace => { | ||
| let batch: WorkspaceDBScheme[] = []; | ||
|
|
||
| const flush = async (): Promise<void> => { |
Member
There was a problem hiding this comment.
for less confusion lets pass the batch into the method, not inherit from the context
e11sy
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces find({}).toArray() over hawk.workspaces with a projected cursor processed in batches of 25. fetchPlans gets a projection too.