feat: forward allowlisted runtime environment to test container - #15
Merged
Merged
Conversation
E2E test report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
runtime-envinput to the root action and run subaction. Callers supply secret values via stepenvand list only newline-delimited variable names in the input. Only the Playwright execution container receives--env NAME; the build, merge, and report containers do not receive the allowlist.Validation accepts portable identifiers, deduplicates names, rejects assignments and reserved runner/process-control variables, and requires every requested variable to be defined and non-empty. Invalid input fails closed as
infrastructure-errorwith phaseruntime-environment, before Docker starts. Errors do not echo raw input or values. Omitting the input preserves existing behavior.README documents the interface, runtime-only credential handling, trusted-code/artifact boundaries, and pending release requirement. Future consumer: https://github.com/Nimbleway/unblocker/pull/3706.
Validation
git diff --check, and all 3 local README links passed.Release dependency
Consumers must wait for a release containing this change under the selected major tag, such as
codotech/playwright-e2e@v0. This PR does not publish a release, move tags, or change consumers to SHA/feature-branch references.