Repository navigation
fix(http): adopt Whoops virtual-source fix in 2.x - #121
Conversation
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Changelog✅ Contribution check passed. Head: Base: Contribution: 1 new valid fragment(s). Policy: ordinary.
|
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Head: bbc0a5d. Tested commit: 4e66fad. PHP CI run. |
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Native STDIN and
php -rexception frames caused Whoops to read virtual filenames, generating extra warnings while rendering the original failure. Adopt Whoops^2.18.7, whose upstream fix preserves those frames while omitting source lookup for virtual sources.Whoops remains optional. A Composer conflict rejects installed versions older than 2.18.7; installation guidance, recipes, the bundled consumer skill and the missing-dependency hint use the same floor. The 2.x PHP 7.4 support, APIs, legacy container, reporting and response policies remain unchanged.
Three bounded PHPUnit process regressions exercise native STDIN,
php -rand a physical file through the existing middleware and renderer. They preserve the original throwable, frames, report order, application warnings, status, caller buffer and callbacks. The native cases fail with Whoops 2.18.6 and pass with 2.18.7.Validation:
Closes #99.