fix(dart): an import or export links the file its URI names, not a namesake

[colbymchenry]

Summary

A Dart import / export now links the file its URI names, or nothing:

• package:<name>/<path> → <root>/lib/<path> of the project package whose pubspec.yaml says name: <name> (the nearest pubspec above an indexed .dart file, never above the project root; the importing file's own package first when names repeat).
• Any other URI → the path from the importing file.
• dart:, a package from outside the repo, a path out of the project, or a file the index doesn't hold → no edge. The ref stays unresolved, i.e. an outside import.

Before, matchByFilePath matched the URI's last segment against file basenames, falling back to a unique same-named file. Otherwise matchByQualifiedName bound the ref to the importing file's own import node, whose qualified name is the URI.

How:

• It reuses fix(dart): a bare call or type name reaches only what its library can see #2386's library model (src/resolution/dart-libraries.ts): a new dartDirectiveFile wraps resolveDartUri.
• resolveViaImport gets a Dart branch.
• Dart imports never fall through to the name-matcher. This is the same guard PHP includes, COBOL copybooks and Nix paths already have.

When packages share a name and neither the importer's own package nor an enclosing one settles it, the importing package's path: dependency of that name picks it. That is read from pubspec_overrides.yaml, then pubspec.yaml, in block or flow style; a git dependency's inner path: doesn't count. bloc's two example apps each keep an authentication_repository. Library visibility reads the same answer.

Validation

riverpod @4ba1be2 and bloc @b9be1e2, native kernel loaded, main @99246848 vs this branch. Every Dart imports edge is classified against an independent oracle, a separate pubspec/URI resolver in the probe script.

Dart imports edges	riverpod before	riverpod after	bloc before	bloc after
to the file the URI names	1,381	2,180	602	1,012
outside package → a project file by basename	223	0	9	0
relative URI → another tree's file (the named one isn't in the repo)	2	0	0	0
to the importing file's own import node	2,044	0	1,042	0
left unresolved	161	1,631	102	743

All edges, paired by call site:

• riverpod (85,482 → 84,012 edges): 1,470 removed, all imports; 799 moved from the own import node to the named file; 1,381 kept, with file-path at 0.7/0.85 becoming import at 0.9. Nothing added, and no other edge kind changed.
• bloc (18,354 → 17,713 edges): 641 removed, all imports; 410 moved to the named file, 23 of them told apart by path:; 602 kept. Nothing added. 37 references / implements / instantiates edges keep their target and go from 0.7 to 0.9, because a file importing package:authentication_repository/… now sees one of the two packages instead of both.

Removed edges, by what they were before:

• riverpod:
  • 1,235 own-import edges of dart: / outside-package URIs.
  • 223 outside packages linked to a namesake. 130 of those were package:flutter/widgets.dart → riverpod_analyzer_utils' riverpod_types/widgets.dart.
  • 12 project paths naming a file the repo doesn't have. These are website/i18n copies of docs pages whose sibling page wasn't translated; 2 of them had gone to website/docs/….
• bloc:
  • 630 own-import edges.
  • 9 namesakes. bloc_tools' package:args/command_runner.dart had linked its own command_runner.dart, and package:integration_test/… had linked test_driver/integration_test.dart.
  • 2 missing files.

Still unresolved though they name a project path: the 12 riverpod i18n copies, bloc's mason template URI {{{bloc_export}}}, and AngularDart's build-generated *.template.dart (2).

Results are identical on #2386's pre-squash commit and on main after #2387: #2387 changes no edge on either repo.

File dependents, which codegraph affected, the MCP file tool's "used by" and dead-code corroboration all read:

• riverpod_analyzer_utils' widgets.dart goes from 132 to 2.
• riverpod's src/core/foundation.dart goes from 51 to 29.
• Distinct cross-file dependency pairs out of riverpod's Dart files go from 7,080 to 7,533.

Tests

• New __tests__/dart-import-uris.test.ts (5 tests). All 5 fail on main (checked at 249d9a8 and 9924684) and pass with the fix, with the kernel and with CODEGRAPH_KERNEL=0.
• tsc --noEmit is clean.
• Full suite with the kernel loaded, on a busy Windows box: 6,233 passed and 11 timed out. The timeouts were all in git-index-currency, index-daemon-rebuild, mcp-status-freshness and sync, and those 4 files pass when rerun alone (78/78).
• An incremental-sync probe works:
  • An importer that changes after its target appears now links the target, including a newly added package.
  • Deleting a target returns its import to unresolved, instead of the own import node.

Not covered

• part / part of directives aren't extracted by either extractor, so they have no edge, before or after.
• sync doesn't retry a failed import when the file it names is added later. Its retry key is the URI's last . segment, dart. It links once the importer changes, or on a full index. Before this change it never re-linked either: it stayed on the own import node.
• Related: open contributor PR fix(resolution): link imported Go and Dart values #1257 resolves Dart value references with its own package: handling. If it is revived, dartDirectiveFile is the shared answer.

🤖 Generated with Claude Code