Repository navigation
Conversation
eitsupi
changed the title
eitsupi
changed the title
eitsupi
changed the title
3 tasks
zeroshade
approved these changes
Sep 26, 2026
Closed
amoeba
pushed a commit
that referenced
this pull request
Sep 30, 2026
Related to #497 ## Summary dbc 0.3.0 silently accepts lockfiles with unsupported versions, including v2 files with source and artifact metadata. During `dbc sync`, it can treat such entries as v1 registry locks and overwrite the file as v1. Validate the top-level version immediately after TOML decoding. Version 1 still loads; versions 2 and later, as well as a missing version, now fail before lock entries are used. A failed sync leaves the lockfile unchanged.
amoeba
pushed a commit
that referenced
this pull request
Sep 30, 2026
Related to #497 ## Summary dbc 0.3.0 silently accepts lockfiles with unsupported versions, including v2 files with source and artifact metadata. During `dbc sync`, it can treat such entries as v1 registry locks and overwrite the file as v1. Validate the top-level version immediately after TOML decoding. Version 1 still loads; versions 2 and later, as well as a missing version, now fail before lock entries are used. A failed sync leaves the lockfile unchanged.
amoeba
pushed a commit
that referenced
this pull request
Sep 30, 2026
Related to #497 ## Summary dbc 0.3.0 silently accepts lockfiles with unsupported versions, including v2 files with source and artifact metadata. During `dbc sync`, it can treat such entries as v1 registry locks and overwrite the file as v1. Validate the top-level version immediately after TOML decoding. Version 1 still loads; versions 2 and later, as well as a missing version, now fail before lock entries are used. A failed sync leaves the lockfile unchanged.
amoeba
pushed a commit
that referenced
this pull request
Sep 30, 2026
Related to #497 ## Summary dbc 0.3.0 silently accepts lockfiles with unsupported versions, including v2 files with source and artifact metadata. During `dbc sync`, it can treat such entries as v1 registry locks and overwrite the file as v1. Validate the top-level version immediately after TOML decoding. Version 1 still loads; versions 2 and later, as well as a missing version, now fail before lock entries are used. A failed sync leaves the lockfile unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #497
Summary
dbc 0.3.0 silently accepts lockfiles with unsupported versions, including v2 files with source and artifact metadata.
During
dbc sync, it can treat such entries as v1 registry locks and overwrite the file as v1.Validate the top-level version immediately after TOML decoding. Version 1 still loads; versions 2 and later, as well as a missing version, now fail before lock entries are used.
A failed sync leaves the lockfile unchanged.