-
-
Notifications
You must be signed in to change notification settings - Fork 334
Feature/ add a tag(--body-length-limit) for command commit #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
aa15fda
1f74bb2
faacc87
071e450
005b422
f514bdd
3dc5471
f17a654
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |||||||||||||||||||||||||||
| import shutil | ||||||||||||||||||||||||||||
| import subprocess | ||||||||||||||||||||||||||||
| import tempfile | ||||||||||||||||||||||||||||
| import textwrap | ||||||||||||||||||||||||||||
| from typing import TYPE_CHECKING, TypedDict | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| import questionary | ||||||||||||||||||||||||||||
|
|
@@ -37,6 +38,7 @@ class CommitArgs(TypedDict, total=False): | |||||||||||||||||||||||||||
| edit: bool | ||||||||||||||||||||||||||||
| extra_cli_args: str | ||||||||||||||||||||||||||||
| message_length_limit: int | ||||||||||||||||||||||||||||
| body_length_limit: int | ||||||||||||||||||||||||||||
| no_retry: bool | ||||||||||||||||||||||||||||
| signoff: bool | ||||||||||||||||||||||||||||
| write_message_to_file: Path | None | ||||||||||||||||||||||||||||
|
|
@@ -84,6 +86,7 @@ def _get_message_by_prompt_commit_questions(self) -> str: | |||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| message = self.cz.message(answers) | ||||||||||||||||||||||||||||
| self._validate_subject_length(message) | ||||||||||||||||||||||||||||
| message = self._rewrap_body(message) | ||||||||||||||||||||||||||||
| return message | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| def _validate_subject_length(self, message: str) -> None: | ||||||||||||||||||||||||||||
|
|
@@ -102,6 +105,31 @@ def _validate_subject_length(self, message: str) -> None: | |||||||||||||||||||||||||||
| f"Length of commit message exceeds limit ({len(subject)}/{message_length_limit}), subject: '{subject}'" | ||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| def _rewrap_body(self, message: str) -> str: | ||||||||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why |
||||||||||||||||||||||||||||
| body_length_limit = self.arguments.get( | ||||||||||||||||||||||||||||
| "body_length_limit", self.config.settings.get("body_length_limit", 0) | ||||||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't use This conveys the right meaning: there must be a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this case, letting it explode can remind programmers that the behavior is not expected (it should always have a value)?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me rephrase it.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We probably need to check if similar patterns exists in the code base. I probably introduced some in the past...
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I got it! Thanks for explaining. In this context, we should raise an error instead of using |
||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||
| # By the contract, body_length_limit is set to 0 for no limit | ||||||||||||||||||||||||||||
| if ( | ||||||||||||||||||||||||||||
| body_length_limit is None or body_length_limit <= 0 | ||||||||||||||||||||||||||||
| ): # do nothing for no limit | ||||||||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Quick question: I understand that the value is guaranteed, but according to defensive programming, isn’t it better to handle the null value?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure whether
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I probably would try
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I found that if I don’t handle None, it can’t commit due to a Null error. |
||||||||||||||||||||||||||||
| return message | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| message_parts = message.split("\n", 2) | ||||||||||||||||||||||||||||
|
yjaw marked this conversation as resolved.
Outdated
|
||||||||||||||||||||||||||||
| if len(message_parts) < 3: | ||||||||||||||||||||||||||||
| return message | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| # First line is subject, second is blank line, rest is body | ||||||||||||||||||||||||||||
| subject = message_parts[0] | ||||||||||||||||||||||||||||
| blank_line = message_parts[1] | ||||||||||||||||||||||||||||
| body = message_parts[2].strip() | ||||||||||||||||||||||||||||
| body_lines = body.split("\n") | ||||||||||||||||||||||||||||
| wrapped_body_lines = [] | ||||||||||||||||||||||||||||
| for line in body_lines: | ||||||||||||||||||||||||||||
| wrapped_body_lines.append(textwrap.fill(line, width=body_length_limit)) | ||||||||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should use Reference: https://docs.python.org/3/library/textwrap.html#textwrap.wrap
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also we should prefer using list comphrehension
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because we want to wrap instead of fill? |
||||||||||||||||||||||||||||
| wrapped_body = "\n".join(wrapped_body_lines) | ||||||||||||||||||||||||||||
| return f"{subject}\n{blank_line}\n{wrapped_body}" | ||||||||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wow, this code is so clean! I Learned a lot. |
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| def manual_edit(self, message: str) -> str: | ||||||||||||||||||||||||||||
| editor = git.get_core_editor() | ||||||||||||||||||||||||||||
| if editor is None: | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -365,3 +365,230 @@ def test_commit_command_with_config_message_length_limit( | |||||
| success_mock.reset_mock() | ||||||
| commands.Commit(config, {"message_length_limit": 0})() | ||||||
| success_mock.assert_called_once() | ||||||
|
|
||||||
|
|
||||||
| @pytest.mark.usefixtures("staging_is_clean") | ||||||
| def test_commit_command_with_body_length_limit_wrapping( | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think all the new tests can be merged into one and use parameterize to shorten the tests Basically we can do like following: fixtures
parameterize
def test_...(...):
mocker.patch(
"questionary.prompt",
return_value={
"prefix": "feat",
"subject": "add feature",
"scope": "",
"is_breaking_change": False,
"body": body, # parameterized, can be a long text with / without line breaks or short strings or an empty string
"footer": "",
},
)
# commit with parameterized config
# check each line in line[2:] does not exceed the line length limit if it is not 0
# file regression check
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand! This will make the test more organized. |
||||||
| config, success_mock: MockType, mocker: MockFixture | ||||||
| ): | ||||||
| """Test that long body lines are automatically wrapped to the specified limit.""" | ||||||
| mocker.patch( | ||||||
| "questionary.prompt", | ||||||
| return_value={ | ||||||
| "prefix": "feat", | ||||||
| "subject": "add feature", | ||||||
| "scope": "", | ||||||
| "is_breaking_change": False, | ||||||
| "body": "This is a very long line that exceeds 72 characters and should be automatically wrapped by the system to fit within the limit", | ||||||
| "footer": "", | ||||||
| }, | ||||||
|
Comment on lines
+411
to
+418
|
||||||
| ) | ||||||
|
|
||||||
| commit_mock = mocker.patch( | ||||||
| "commitizen.git.commit", return_value=cmd.Command("success", "", b"", b"", 0) | ||||||
| ) | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please reuse |
||||||
|
|
||||||
| # Execute with body_length_limit | ||||||
| commands.Commit(config, {"body_length_limit": 72})() | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The number 72 should be extracted. |
||||||
| success_mock.assert_called_once() | ||||||
|
|
||||||
| # Verify wrapping occurred | ||||||
| committed_message = commit_mock.call_args[0][0] | ||||||
| lines = committed_message.split("\n") | ||||||
| assert lines[0] == "feat: add feature" | ||||||
| assert lines[1] == "" | ||||||
| body_lines = lines[2:] | ||||||
| for line in body_lines: | ||||||
| if line.strip(): | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe so. This line was intended to skip empty lines, which are no longer necessary. |
||||||
| assert len(line) <= 72, ( | ||||||
| f"Line exceeds 72 chars: '{line}' ({len(line)} chars)" | ||||||
| ) | ||||||
|
|
||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a file regression check here and remove |
||||||
|
|
||||||
| @pytest.mark.usefixtures("staging_is_clean") | ||||||
| def test_commit_command_with_body_length_limit_preserves_line_breaks( | ||||||
| config, success_mock: MockType, mocker: MockFixture | ||||||
| ): | ||||||
| """Test that intentional line breaks (from | character) are preserved.""" | ||||||
| # Simulate what happens after multiple_line_breaker processes "line1 | line2 | line3" | ||||||
| mocker.patch( | ||||||
| "questionary.prompt", | ||||||
| return_value={ | ||||||
| "prefix": "feat", | ||||||
| "subject": "add feature", | ||||||
| "scope": "", | ||||||
| "is_breaking_change": False, | ||||||
| "body": "Line1 that is very long and exceeds the limit\nLine2 that is very long and exceeds the limit\nLine3 that is very long and exceeds the limit", | ||||||
| "footer": "", | ||||||
| }, | ||||||
| ) | ||||||
|
|
||||||
| commit_mock = mocker.patch( | ||||||
| "commitizen.git.commit", return_value=cmd.Command("success", "", b"", b"", 0) | ||||||
| ) | ||||||
|
|
||||||
| commands.Commit(config, {"body_length_limit": 45})() | ||||||
| success_mock.assert_called_once() | ||||||
|
|
||||||
| committed_message = commit_mock.call_args[0][0] | ||||||
| lines = committed_message.split("\n") | ||||||
|
|
||||||
| # Should have a subject, a blank line | ||||||
| assert lines[0] == "feat: add feature" | ||||||
| assert lines[1] == "" | ||||||
| # Each original line should be wrapped separately, preserving the line breaks | ||||||
| body_lines = lines[2:] | ||||||
| # All lines should be <= 45 chars | ||||||
| for line in body_lines: | ||||||
| if line.strip(): | ||||||
| assert len(line) == 45, ( | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this test case, every line is exactly 45 characters long, so I check if it truly wraps to 45-character lines. However, there’s a case where it wraps to a line shorter than 45 characters which is not the intended behavior but test still can pass.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is strange. Wrapping should not guarantee exactly N chars long.
|
||||||
| assert len(line) == 45, ( | |
| assert len(line) <= 45, ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can set a default value here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. What’s the difference between setting a default value here and using default_setting in defaults.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think
DEFAULT_SETTINGSis not a good design. I am not sure the mechanism of default value inargparse, not sure the exact difference here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally the default should be in DEFAULT_SETTINGS, which can be updated from the .cz.toml file. A default in argparse may override the setting in the file. You can add a test, to check that this is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that multiple default setting is undesirable. Should I remove the default setting for this tag from
cli.py?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after a second look, there should not be default values in cli.py because we want cz to use the settings from the configuration file if the value is None in arguments