Add support for Markdown rendering for YAML front matter#434
Open
stupar73 wants to merge 3 commits into
Open
Conversation
robinst
reviewed
May 11, 2026
|
|
||
| private boolean isFlowCollection(String value) { | ||
| return (value.startsWith("[") && value.endsWith("]")) | ||
| || (value.startsWith("{") && value.endsWith("}")); |
Collaborator
There was a problem hiding this comment.
All this special handling is a bit unfortunate, we should probably never have started trying to parse the YAML ourselves (but treat it as an opaque blob instead). See also this issue:
Having said that, it is what we currently do so what you have here LGTM.
Author
There was a problem hiding this comment.
Yeah agreed, it feels a bit like it shouldn't be this libraries responsibility to handle the content of the YAML front matter.
But as you say, that's what we currently do, and I think this is an net positive from the current state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonmark-ext-yaml-front-matterdoes not currently support rendering to Markdown, this PR adds that functionality.The below block will be rendered at the top of the markdown file (containing the actual key-value pairs):