Repository navigation
Preserve indent inside unclosed inline HTML attributes - #312
Open
mamicicekel wants to merge 1 commit into
Open
mamicicekel wants to merge 1 commit into
mamicicekel wants to merge 1 commit into
Conversation
Paragraph indent stripping was applied before the inline parser, so a newline inside a raw HTML tag dropped spaces that change the attribute value. Keep that indent when the paragraph is still inside an unclosed tag. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paragraph continuation lines skip leading indentation before the inline parser runs. That is correct for ordinary text, but it also rewrites raw HTML that spans lines. A tag such as
<a class="abc d e f">text</a>was parsed as
class="abc\nd e f", which changes the attribute. Block HTML already keeps the spaces.addLinenow restores the skipped indent when the paragraph still ends inside an unclosed HTML tag, comment, PI, declaration, or CDATA section. Ordinary paragraph indent is unchanged.Fixes #303.
Test plan
npm test— 748 passed, including a regression case from White space handling looks inconsistent between HTML block element vs HTML inline element #303npm run lintMade with Cursor