Repository navigation
Enable xeus-cpp to be built as an llvm external project for Emscripten build, and enable xeus-cpp to use Emscripten static library build of CppInterOp - #499
Open
mcbarton wants to merge 9 commits into
Conversation
Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
xeus-cpps cppinterop-v2.0 branch needs rebasing on the main branch, in order to remove most of the commits currently showing in this PR (and to show the exact diff relevant to this PR goal). |
Collaborator
Author
|
Just in case it isn't obvious, the deployment ci will not pass for this PR, since it is pointing to a branch targetting CppInterOp v2.0, with CppInterOp v1.9.0 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables xeus-cpp to be built as an llvm external project for the Emscripten build, and enable xeus-cpp to use Emscripten static library build of CppInterOp.
The build which doesn't build xeus-cpp as part of llvm currently requires compiler-research/CppInterOp#1149 which is this PR targets the cppinterop-v2.0 branch
This PR is such that the xeus-cpp will build with whatever CppInterOp library happens to be available. It doesn't care if CppInterOp is a shared or static library. The tests pass regardless.