Skip to content

Remove unused buffer variable from xassist.cpp - #502

Merged
mcbarton merged 1 commit into
compiler-research:mainfrom
mcbarton:Unused-variable-native-build
Oct 21, 2026
Merged

mcbarton merged 1 commit into
compiler-research:mainfrom
mcbarton:Unused-variable-native-build

Conversation

@mcbarton

Copy link
Copy Markdown
Collaborator

When I opened up #496, I forgot to check the native build. When I did the native build I found another unused variable

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.90%. Comparing base (6fbc3f4) to head (10f8786).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   72.84%   72.90%   +0.06%     
==========================================
  Files          18       18              
  Lines        1204     1203       -1     
  Branches      113      113              
==========================================
  Hits          877      877              
+ Misses        327      326       -1     
Files with missing lines Coverage Δ
src/xmagics/xassist.cpp 72.98% <ø> (+0.29%) ⬆️
Files with missing lines Coverage Δ
src/xmagics/xassist.cpp 72.98% <ø> (+0.29%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491 anutosh491 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@mcbarton
mcbarton merged commit 65584a8 into compiler-research:main Oct 21, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants