Java HTTP Options update - v10.0.0 update#683
Merged
Conversation
laliconfigcat
previously approved these changes
May 6, 2026
adams85
requested changes
May 11, 2026
Comment on lines
832
to
833
Contributor
There was a problem hiding this comment.
This warning doesn't seem to make sense anymore, so we should remove it.
Suggested change
Contributor
Author
There was a problem hiding this comment.
The first part remains true. I think we can remove the 2nd half, "refrain from closing the HTTP client manually."
Contributor
There was a problem hiding this comment.
After all, the first part remains true.
It's just that the whole message isn't really relevant to users anymore since they can't pass an externally created http client to the SDK.
Deploying configcat-docs with
|
| Latest commit: |
1dfbff1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acb6365f.docs-xmy.pages.dev |
| Branch Preview URL: | https://java-http-options-update.docs-xmy.pages.dev |
adams85
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Related issues (only if applicable)
How to test? (only if applicable)
Requirement checklist