Skip to content

Fetch retry - #46

Merged
kp-cat merged 5 commits into
masterfrom
fetch-retry
Oct 9, 2026
Merged

kp-cat merged 5 commits into
masterfrom
fetch-retry

Conversation

@kp-cat

@kp-cat kp-cat commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Describe the purpose of your pull request

  • Config fetch retry logic
  • Accept only 200 status code response
  • Empty string + null Config JSON validation
  • Log CF Ray ID

Related issues (only if applicable)

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@kp-cat
kp-cat requested a review from a team as a code owner October 1, 2026 13:42
@kp-cat
kp-cat requested a review from adams85 October 1, 2026 13:44
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.20635% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.58%. Comparing base (afbd8bf) to head (1303c39).

Files with missing lines Patch % Lines
lib/configcat/version.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   98.54%   98.58%   +0.04%     
==========================================
  Files          40       40              
  Lines        3358     3466     +108     
==========================================
+ Hits         3309     3417     +108     
  Misses         49       49              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…emain accessible even if the body download fails

@adams85 adams85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, only a minor piece is missing: other SDKs also log the CF Ray ID for 1104 errors. (E.g., https://github.com/configcat/java-sdk/blob/0b6875f20161546635c2f2a1f08dc355834cc1c6/src/main/java/com/configcat/ConfigFetcher.java#L89)

Could you add this here too?

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@kp-cat
kp-cat requested a review from adams85 October 9, 2026 09:10
@kp-cat
kp-cat merged commit 305e080 into master Oct 9, 2026
14 checks passed
@kp-cat
kp-cat deleted the fetch-retry branch October 9, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants