feat(promql): typed duration builders (seconds/minutes/.../duration)#96
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds typed duration builders to
promql-astso callers never hand-assemble PromQL duration syntax with string interpolation (e.g.`${n}s`). The syntax now lives in the package, which is the whole point of the AST.New exports:
seconds,minutes,hours,days,weeks,years,milliseconds, and the compositeduration({ y,w,d,h,m,s,ms })(throws on an empty spec). A brandedDurationtype is added;range/subquery/offsetnow takeDurationinstead ofstring.Backwards compatible:
Duration's brand is optional, so existing call sites passing plain string literals (range(sel, '5m')) still typecheck.Version bump
0.2.1 → 0.3.0.Tests
+3 tests (duration composition, empty-spec rejection,
range(metric, seconds(60))→x[60s]). Full suite 51 green;tscclean;makage build(CJS+ESM) green.Follow-up
constructive-db#2275's collector will use
seconds()for its rate window instead of`${rateWindowSeconds}s`once this is published.Link to Devin session: https://app.devin.ai/sessions/16409487e97d44828dfb46277767604b
Requested by: @pyramation