fix(deparser): MergeWhenClause support and SecLabelStmt qualified object names#304
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pgsql-deparser bugs found while fuzzing constructive-db's schema transform:
Top-level
MERGEcould not deparse at all —MergeStmtvisited itsmergeWhenClauses, but there was noMergeWhenClausevisitor, so every MERGE failed withDeparser does not handle node type: MergeWhenClause. Added the visitor covering:MERGE_WHEN_MATCHED/NOT MATCHED [BY TARGET]/NOT MATCHED BY SOURCEAND <condition>CMD_UPDATE(UPDATE SETvia the same ResTarget/update context asUpdateStmt),CMD_INSERT(columns,OVERRIDING {USER|SYSTEM} VALUE,VALUES (...)/DEFAULT VALUES),CMD_DELETE,CMD_NOTHING(DO NOTHING)MergeStmt.returningListhandling (MERGE ... RETURNING, PG17)SecLabelStmtemitted invalid qualified names —SECURITY LABEL ... ON COLUMN a.b.cdeparsed toON COLUMN "a", b, cbecause the objectListwas visited generically (comma-joined). Now dot-joined, matchingCommentStmt's existing handling.Fixtures added via the kitchen-sink pipeline (
__fixtures__/kitchen-sink/misc/merge-seclabel.sql, 8 statements round-tripped in both plain and pretty modes). Full deparser suite passes (713 tests).Link to Devin session: https://app.devin.ai/sessions/eeb8deba0c04475091df703c88877302
Requested by: @pyramation