Skip to content

fix: reject invalid network ls filters - #5226

Open
immanuwell wants to merge 1 commit into
containerd:mainfrom
immanuwell:fix/network-ls-invalid-filters
Open

immanuwell wants to merge 1 commit into
containerd:mainfrom
immanuwell:fix/network-ls-invalid-filters

Conversation

@immanuwell

@immanuwell immanuwell commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

network ls --filter names=missing lists every configured network

This rejects unknown keys and filters without =, valid name and label filters still work

Repro with CNI plugins installed:

nerdctl network create repro-net
nerdctl network ls --filter names=missing

Before: lists repro-net. After: exits with invalid filter 'names'

Tested: make test-unit and golangci-lint run ./pkg/cmd/network/...

Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant