posix filesystem call test suite based on pjdfstest#104
Draft
sequix wants to merge 1 commit intocontainerd:mainfrom
Draft
posix filesystem call test suite based on pjdfstest#104sequix wants to merge 1 commit intocontainerd:mainfrom
sequix wants to merge 1 commit intocontainerd:mainfrom
Conversation
Member
|
@sequix please sign off thanks |
Signed-off-by: sequix <sequix@163.com>
Author
signed |
ktock
reviewed
May 28, 2020
| # basic packages | ||
| RUN apt-get update -y && \ | ||
| apt-get --no-install-recommends install -y libbtrfs-dev libseccomp-dev fuse \ | ||
| apt-transport-https gnupg2 software-properties-common |
Member
There was a problem hiding this comment.
I mean apt-transport-https gnupg2 software-properties-common.
| set -euo pipefail | ||
|
|
||
| # Check Dockerfile at script/posix/Dockerfile | ||
| IMAGE_PJDFSTEST="${IMAGE_PJDFSTEST:-docker.io/sequix/pjdfstest:v1-stargz}" |
Member
There was a problem hiding this comment.
I'll also upload it when we merge it.
Comment on lines
+86
to
+87
| ctr-remote run --rm --snapshotter=stargz "$IMAGE_PJDFSTEST" "$containerID" >/output || \ | ||
| echo -e "\e[91mPosix test failed!\e[0m" |
Member
There was a problem hiding this comment.
We should propagate the exit code to the caller scripts (test.sh) so that Github Actions can know the success/failure of this test.
Member
|
@sequix thanks! but we need your real name :P |
Author
Looks like the ltp community is pretty active, not like pjdfstest. I will git ltp a try. |
Member
|
Is this still on plan? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#101 covers performance test, this PR covers posix calls with (pjd/pjdfstest)[https://github.com/pjd/pjdfstest]. It uses perl TAP-Harness to mock posix calls and its test case is written in script like.
You can see this will create files on the rw layer, but I still got some errors, At first I thought this is about the container environment, but the errors disappear when I switched to oci image.
Interpretation of above log:
Correspond to the 5th and 10th
expectstatement of filehttps://github.com/pjd/pjdfstest/blob/master/tests/chown/02.t. After exmaine all failed tests, they allexpect ENAMETOOLONG.Maybe later we can build tests in ro layer based on this.