fix: validate source files exist before applying patch#101
Open
rosygmiki wants to merge 4 commits into
Open
Conversation
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in pkg/tar-patch/apply.go where an error encountered while closing the current file was being ignored and nil was returned instead of the actual error. The code has been corrected to return the err. There are no review comments to address.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 79.19% 78.35% -0.85%
==========================================
Files 10 10
Lines 1115 1164 +49
==========================================
+ Hits 883 912 +29
- Misses 134 145 +11
- Partials 98 107 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ion for broader compatibility Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
rosygmiki
changed the title
rosygmiki
force-pushed
the
windows-system-test
branch
3 times, most recently
from
39984c8 to
b3fbf61
Compare
…tching the delta Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
rosygmiki
force-pushed
the
windows-system-test
branch
from
b3fbf61 to
27f0279
Compare
- Replace os.IsNotExist() with errors.Is(err, os.ErrNotExist) for proper error unwrapping on both Linux and Windows - Ensures "The system cannot find the file specified" on Windows is correctly detected as file-not-found error - Update test to strictly require failure when source file is missing Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Windows builds would fail or produce unexpected/partial output when source files were missing. It also cleans up our CI workflow by removing unsupported platforms.
Fixes
Adds a validation function to
pkg/tar-patch/apply.goto verify delta files against the source directory before applying the delta patch. This prevents unexpected or partial output.Chores
Closes #84