Repository navigation
fix(data): stale notes, one outline for the descriptions (T2 of #449) - #460
Merged
Merged
Conversation
- bryson_denham: JuMP is valid (it passes the convergence and robustness crons with the objective of OptimalControl); its note on ASCII names was no longer true. - mountain_car: the note puts the 1.6e-4 gap on the configuration exa + MadNLP, in both OptimalControl modelings, not on the scalarized modeling. - Descriptions: "Characteristics" keeps what cannot be computed; the dimensions, final time and kinds of constraints are shown on the problem page from `features` (one source of truth). Horizontal rules removed, `robbins` gets its "Mathematical formulation" heading, `space_shuttle` its "References", and a broken `\text` of `balanced_field` is fixed. - test_consistency: every description follows one outline. Refs #449 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the figures Refs #449 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The OptimalControl model declares `x ∈ R²`, whose components are x₁, x₂; the JuMP model names them x1, x2. The comparison of the modelings fails on it (test_features). Refs #449 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 19, 2026
# Conflicts: # ext/MetaData/mountain_car.jl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #449 (T2, findings). Applied conventions:
ct-conventions v0.14.0,ct-agents v0.5.0.Fixes findings 2–4 of the T2 review (finding 1 was wrong, see below).
Changes
Reverted: the note is right. The OptimalControl model declaresbryson_denham: JuMP:draft→:valid.x ∈ R², whose components arex₁,x₂, and the JuMP model names themx1,x2; the first CI run failed on it (test_features). The review had only looked at the parameter names. Unchanged here.mountain_car: note rewritten. The gap (102.381 against 102.398) comes frommodeler=exa solver=madnlp, in both OptimalControl modelings. It does not come from the scalarized modeling: Ipopt gives 102.3976 in every modeling.test_outlineintest_consistency.jl:robbinsgets its "Mathematical formulation" heading,space_shuttleits "References" (it was "References and relevance"), and the horizontal rules between sections are removed (4 files).features(docs/problems.jl,facts). What remains is the nature of the dynamics, the structure of the solution, and why the problem is a benchmark.Also: a broken
\textin the formulation ofbalanced_field(a tab had replaced\t:ext{ m (35 ft)}).Left open
### Parameterssection from the metadata (parameters_sectionindocs/problems.jl), so 5 pages show two sections named "Parameters", and the values are written twice. The hand-written ones also give the meaning and the unit of each parameter, which the metadata do not have. Either the metadata gain the meaning and unit of each parameter, shown by the generated section, or the descriptions keep only the meaning, without values. This is the maintainer's call, in a follow-up.balanced_fieldhas no "Qualitative behaviour". Its source (the Dymos example) does not describe the solution. The section stays optional in the descriptions; the page of a problem without one gets a placeholder that points to the figures (with_behaviourindocs/problems.jl), so every page has the same outline. It can be written from the cron plots.Test plan
Pkg.test(; test_args=["core"]): 1334 passed, 1 broken (the existing@test_skipoftest_discovery_cache.jl).🤖 Generated with Claude Code