Repository navigation
refactor(ext): qualified imports in the OptimalControl and JuMP extensions (MOD4) - #471
Merged
Merged
Conversation
…sions (MOD4, T3 of #449) The names the model files use everywhere are imported by name (backends, parameters_data, grid_size_data, @def); the accessors of JuMPModels are qualified. The cart_pendulum comment on J points to the check of the formulations (T6/T7). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
16 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #449 (T3). Conventions: ct-conventions v0.14.0, ct-agents v0.5.0.
Summary
ext/OptimalControlModels.jl,ext/JuMPModels.jl: no bareusingany more (MOD4). The names the model files use everywhere come by name (OptimalControlBackend,OptimalControlScalarizedBackend,JuMPBackend,parameters_data,grid_size_data, the macro@def; MOD4 keeps names for macros and pervasive symbols), so the ~60 model files are unchanged. The accessors JuMPModels calls are qualified (CTModels.Models.state_dimension,CTModels.Components.time_grid,JuMP.objective_value, …). Unused imports removed (DocStringExtensionsin OptimalControlModels,OrderedDict).cart_pendulum(OptimalControl): the comment onJ = mcartnow says what to check and where:∂eq/∂ddxwould be-(m + mcart), to check against the source in T6/T7. The model is unchanged.Test plan
Pkg.test(; test_args=["JuMP", "OptimalControl", "OptimalControlScalarized", "comparison"]), every problem: 1290 passed.🤖 Generated with Claude Code