Skip to content

refactor(metadata): no grid without a modeling (T4 of #449) - #475

Merged
ocots merged 1 commit into
mainfrom
refactor/grid-by-modeling-only
Nov 20, 2026
Merged

ocots merged 1 commit into
mainfrom
refactor/grid-by-modeling-only

Conversation

@ocots

@ocots ocots commented Nov 20, 2026

Copy link
Copy Markdown
Member

Refs #449 (T4, findings 1, 4, 5 of the review), #435. Conventions: ct-conventions v0.14.0, ct-agents v0.5.0.

Summary

  • Breaking: grid_size_data(problem) is removed; grid_size_data(problem, backend) (feat(metadata): the grid of a problem by modeling, coarser for ModelingToolkit (#435) #473) is the only grid function. The grid depends on the modeling (coarser for ModelingToolkit, or :grid_sizes), and three tests that solve in a modeling reported the grid of the problem: the JuMP convergence cron, the JuMP and OptimalControl robustness. Same value today, wrong as soon as a problem has :grid_sizes. The field :grid_size of the metadata stays, the default of the modelings. A test checks that the one-argument form is gone. BREAKING, CHANGELOG and the guides updated; the migration page gets a section on the grid and the references (feat(references): the references by modeling, each from its own solves (#435) #474 had missed it).
  • test/extras/beam.jl removed: a dead script (Pkg.activate("test"), bare using, Plots), never run nor referenced.
  • test/README.md: the modelings are independent (configurations, grid, references by modeling); the one solve comparison (beam in test_solution); the ModelingToolkit solves (coarse grid, quasi-Newton Hessian, warmup, references of its own).

Findings 2 and 3 (one set of shared tests for the four modelings, a table modeling × kind of test) come in a second PR.

Test plan

  • core: 2340 passed.
  • JuMP cron, JuMP robustness, OptimalControl robustness on beam: passed.
  • docs/preview.sh build: built.
  • CI.

🤖 Generated with Claude Code

…m, backend) only (T4 of #449)

The one-argument grid_size_data is removed (breaking): the grid depends on the modeling
(#473), and three tests solving in a modeling reported the grid of the problem. The JuMP
convergence cron and the JuMP and OptimalControl robustness tests report the grid of their
modeling. The dead test/extras/beam.jl is removed; test/README.md says the modelings are
independent and what the ModelingToolkit solves do since #472-#474; the migration page
covers the grid and the references.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ocots ocots added the run ci github-runner Trigger the CI workflow on GitHub-hosted runners label Nov 20, 2026
@ocots
ocots merged commit f38800d into main Nov 20, 2026
17 of 18 checks passed
@ocots
ocots deleted the refactor/grid-by-modeling-only branch November 20, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ci github-runner Trigger the CI workflow on GitHub-hosted runners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant