Repository navigation
refactor(metadata): no grid without a modeling (T4 of #449) - #475
Merged
Merged
Conversation
…m, backend) only (T4 of #449) The one-argument grid_size_data is removed (breaking): the grid depends on the modeling (#473), and three tests solving in a modeling reported the grid of the problem. The JuMP convergence cron and the JuMP and OptimalControl robustness tests report the grid of their modeling. The dead test/extras/beam.jl is removed; test/README.md says the modelings are independent and what the ModelingToolkit solves do since #472-#474; the migration page covers the grid and the references. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 3 tasks
16 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #449 (T4, findings 1, 4, 5 of the review), #435. Conventions: ct-conventions v0.14.0, ct-agents v0.5.0.
Summary
grid_size_data(problem)is removed;grid_size_data(problem, backend)(feat(metadata): the grid of a problem by modeling, coarser for ModelingToolkit (#435) #473) is the only grid function. The grid depends on the modeling (coarser for ModelingToolkit, or:grid_sizes), and three tests that solve in a modeling reported the grid of the problem: the JuMP convergence cron, the JuMP and OptimalControl robustness. Same value today, wrong as soon as a problem has:grid_sizes. The field:grid_sizeof the metadata stays, the default of the modelings. A test checks that the one-argument form is gone. BREAKING, CHANGELOG and the guides updated; the migration page gets a section on the grid and the references (feat(references): the references by modeling, each from its own solves (#435) #474 had missed it).test/extras/beam.jlremoved: a dead script (Pkg.activate("test"), bareusing, Plots), never run nor referenced.test/README.md: the modelings are independent (configurations, grid, references by modeling); the one solve comparison (beamintest_solution); the ModelingToolkit solves (coarse grid, quasi-Newton Hessian, warmup, references of its own).Findings 2 and 3 (one set of shared tests for the four modelings, a table modeling × kind of test) come in a second PR.
Test plan
core: 2340 passed.JuMP cron,JuMP robustness,OptimalControl robustnessonbeam: passed.docs/preview.sh build: built.🤖 Generated with Claude Code