Repository navigation
Release - #122
Merged
Merged
Release#122
Conversation
- GitHub renders the summary of each step as a Markdown document of its own and joins them with a blank line, so the reviewers, written by a later step than the rest, ended up as a list of their own rather than as the last item of the one above them. - The summary is therefore written last, by a step that does nothing else, out of the outputs of the steps that produced the values. The step that requests the reviews now records the users in outputs instead of writing them to the summary itself. - The step runs unless the run was cancelled, rather than only on success, so that a failure after the pull request was opened still leaves its URL in the summary. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- GitHub renders every newline of a comment as a line break, so a hard-wrapped checklist item reaches the pull request broken across lines. The items this workflow contributes were already joined by a line continuation, but nothing said so to the callers that supply their own, and theirs arrive wrapped. The description of both inputs now states it. - The continuation of the common pre-deployment item was aligned under the text it continues, and that alignment survived the join as a run of seven spaces in the comment body. It now continues without indentation, as the tip above it already does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…on-format-128b67 task-release: Fix the formatting of the Markdown it writes
- The other values of the same list are sentences or identifiers that begin with a capital letter, and the placeholder standing in for an empty list of reviewers did not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…-nobody task-release: Capitalize the reviewer placeholder of the job summary
The readme opened its recommendation with a bare U+26A0 WARNING SIGN, which browsers and terminals drew as a monochrome outline instead of the yellow triangle it was meant to be. - U+26A0 has the Unicode property `Emoji_Presentation = No`, which makes it a text-default character: a renderer draws its plain text glyph unless it is asked for the emoji one. The glyph therefore came from the first font in the stack that covers the character, such as Segoe UI Symbol, DejaVu Sans or Noto Sans Symbols, and the color emoji font was never reached. - Appending U+FE0F VARIATION SELECTOR-16 requests emoji presentation for the character preceding it. That is what characters colored by default, such as U+1F6A7 CONSTRUCTION SIGN, already carry implicitly. - GitHub's `:warning:` shortcode produces a yellow triangle too, but only in GitHub Flavored Markdown. It stays literal text in every other renderer, and this file is read outside the web interface as well. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…f1e03 docs: Render the warning sign in color
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes