Repository navigation
workflows: Use reusable workflow for release and publication task - #1060
Merged
Merged
Conversation
- The workflow was a copy of the one in `lib-cl-sii-python` and `lib-cl-sii-api-python`, so a fix or an improvement had to be applied twice. - The reusable workflow is `cordada/github-actions-utils`, which already hosts the Git commit linter and Super-Linter workflows. - What this VCS repository does with a release is publish a package, not deploy it, so the workflow is renamed accordingly. - The pull request labels have to be overridden because this VCS repository still labels a publication pull request `kind: deploy`, and a label that does not exist cannot be applied.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| uses: cordada/github-actions-utils/.github/workflows/task-release-and-publish.yaml@master |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This VCS repository's
Task: Release and Deployworkflow was a byte-for-byte copy of the one in the otherlib-cl-sii-*VCS repository, so a fix or an improvement had to be applied twice. It now calls the reusable workflow added in cordada/github-actions-utils#114, and is renamed, because what this VCS repository does with a release is publish a package rather than deploy one.Decisions Somebody Should Weigh In On
taskandkind: publishby default, but this VCS repository has nokind: publishlabel, so the caller overrides the default withkind: deploy. Creating the label here and dropping the override is the tidier end state, andgh pr createfails outright on a label that does not exist, so it cannot be done in the other order.publish/…rather thandeploy/…. Nothing in this VCS repository keys on that prefix, but anybody who filters branches by hand will notice.deploy.yamland thedeployjob ofci-cd.yamlhave the same naming problem and are untouched here, because renaming them is unrelated to this change.What I Could Not Verify
release/…pull request is merged intodevelop, so the first real release after this is merged is the actual test.