Repository navigation
workflows: Label a release publication kind: publish - #1061
Merged
Merged
Conversation
- The 'Task: Release and Publish' workflow now names the VCS branch `publish/vX.Y.Z` and titles the pull request `Publish release vX.Y.Z`, so the manual procedure documented here no longer matched what actually happens. - The label is `kind: publish`, which is the renamed `kind: deploy`.
- The override existed only because this VCS repository had no `kind: publish` label, which is what the reusable workflow labels a publication pull request by default. - That label now exists: `kind: deploy` was renamed rather than replaced, so the pull requests that already carried it keep it.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
Task: Release and Publishworkflow labels its pull requesttaskandkind: publish, which is the reusable workflow's default, but this VCS repository had no such label, so the caller was overriding the default withkind: deploy. The label has now been renamed rather than replaced, so the pull requests that already carriedkind: deploycarrykind: publishinstead, and the release history stays under one label rather than split across two.Also In Here
CONTRIBUTING.mdstill described the manual procedure as producing adeploy/vX.Y.Zbranch and aDeploy release vX.Y.Zpull request. The workflow has producedpublish/…andPublish release …since it started calling the reusable workflow, so that section was already wrong and is corrected here.What I Could Not Verify
kind: deploylabel that no longer exists, andgh pr createfails outright on a label it cannot find. A release merged intodevelopin that window would fail at the pull request step. Nothing else is affected, and merging this closes the window.deployjob ofci-cd.yamlanddeploy.yamlname the PyPI upload a deployment, which is the same terminology problem one layer down. They are untouched, because renaming them is a separate change.