Repository navigation
workflows: Rename workflow "Deploy" to "Publish" - #1064
Merged
Merged
Conversation
- Rename workflow file `deploy.yaml` to `publish.yaml`, its `name`, its job and its only step, and the caller job in `ci-cd.yaml`. - The workflow does not deploy anything: it uploads the built distribution to a package registry, which the rest of the repository already calls publishing, as in `task-release-and-publish.yaml`, the `publish/vX.Y.Z` branches, the `kind: publish` pull request label, and the note in `CONTRIBUTING.md` that by "deploy" it is meant publish to the package registry. - Keep input `deploy_env` and variable `DEPLOY_ENV` as they are, because they name the deployment environment rather than this workflow, and `release.yaml` takes the same input. - Keep Make target `deploy` as it is, because renaming it is not part of renaming the workflow. - Renaming changes the name of the check this workflow reports, and no branch protection rule of either `develop` or `master` requires it. Ref: cordada/lib-cl-sii-api-python#1132
jtrobles-cdd
force-pushed
the
rename-deploy-workflow-to-publish
branch
from
September 10, 2026 18:58
06aa85e to
8fa9c66
Compare
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow called
Deploydoes not deploy anything: it uploads the built distribution to PyPI. Everything else in the repository already calls that publishing —task-release-and-publish.yaml, thepublish/vX.Y.Zbranches, thekind: publishpull request label, andCONTRIBUTING.md, which has to explain that by "deploy" it means publish to the package registry.Changes
.github/workflows/deploy.yamlto.github/workflows/publish.yaml, along with itsname, its job, its only step and the header comment.ci-cd.yamland point it at the new file.Deliberately Unchanged
deploy_envnames the deployment environment rather than this workflow, andrelease.yamltakes the same input, so renaming it is a different change.deployis not part of the workflow.CONTRIBUTING.mdandREADME.mddescribe deployment environments and the release procedure, not this workflow by name.For The Reviewer
Deploy / DeploytoPublish / Publish. No branch protection rule ofdevelopormasterlists it among its required status checks, so nothing has to be reconfigured; the required contexts areCI / Test,Git Commit Linter / Test,Super-Linter / Test,Dependency Reviewandcodecov/project.master, so neither this pull request nor thedeveloprun after the merge exercises it. The renamed job can only be seen during the next publication.