Repository navigation
fix: keep CachedImage names within the 63-char label limit - #196
Merged
Merged
Conversation
added 4 commits
October 23, 2026 16:15
CachedImage names are used as the drop.corewire.io/cachedimage label on pull
Pods, and CachedImageSet names as the drop.corewire.io/imageset label on
children. Child names could reach 253 chars, so pull Pod creation was
rejected ("must be no more than 63 bytes").
- Reject CachedImage and CachedImageSet names over 63 chars via CEL.
- Name children <image>-<tag>-<hash> (hash covers parent + ref), capped at 63.
- Recreate existing children whose name no longer matches.
- Add unit, envtest and chainsaw e2e coverage.
Resolves govulncheck findings GO-2026-6599..6809 (crypto/x509, crypto/tls, net/http, http2, html/template, net/textproto).
The manager cached every Pod, Secret and full Node in the cluster. On a cluster with ~3000 Pods and 144 build Nodes (large status.images) it was OOMKilled at the 128Mi limit within seconds of starting. - Pod and Secret informers are limited to the pod namespace (all reads already target only that namespace). - Node status.images (never read) is dropped from the cache. - managedFields are stripped from all cached objects.
v2.13.2 cannot load go1.27.3 export data (typecheck failures in stdlib imports).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Pods were rejected for CachedImageSet children with names > 63 chars (label value limit).
<image>-<tag>-<hash>(hash covers parent + ref), capped at 63cachedimageset-long-names) coverageNote: unit tests not run locally; relying on CI.