Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a feature request contains no spikes from the stored waveform reservoir,
TemplateModel.get_features()attempts PCA on an empty array and raisesZeroDivisionError. This surfaced in Phy's ordinary Feature View while testing a subsampled waveform export.Return the existing zero-filled feature tensor for missing coverage and preserve empty spike/channel selection shapes. Full and partial waveform projection keep their current behavior.
Validation: five regression cases use a real on-disk sorting. Three empty-input cases fail before the fix; all five pass afterward. The complete isolated suite passes 308 tests, and flake8 passes. Existing Phy/phylib environments are unchanged.
This is a separate dependency fix discovered during cortex-lab/phy#1428 validation. Bounded mode already filters requests against stored waveform IDs, so #1428 does not require a dependency bump for this guard.
Real-data validation: reopened a separate copy of the 469,725,567-spike converted test sorting in the ordinary main Phy GUI with this isolated phylib revision. The process exited zero with no tracebacks (the unchanged dependency produced five Feature View errors during the equivalent reopen). Complete assignments and group/notes files were byte-identical before and after the no-edit save. Original validation outputs and installed environments were retained. This is software integration evidence on a conversion with unverified acquisition exposure.
Cross-platform CI and minimum SpikeInterface compatibility passed.