Repository navigation
Owner-only files and directories on Windows - #19
Closed
subc-alfonso[bot] wants to merge 2 commits into
Closed
subc-alfonso[bot] wants to merge 2 commits into
subc-alfonso[bot] wants to merge 2 commits into
Conversation
|
This PR needs a linked issue with the |
ualtinok
force-pushed
the
windows-owner-only
branch
from
October 8, 2026 22:35
cb22784 to
5ece3c0
Compare
…ortexkit-log 0.3.5, cortexkit-store 0.2.4) protect_file and create_private_dir did nothing on Windows and still returned Ok, so stores and logs kept whatever the parent folder granted. They now set a protected DACL whose only entry grants the current user full control: new directories get it at creation, and narrowing an existing directory propagates to the files already inside. cortexkit-log uses the same helpers. Unix and other platforms are unchanged.
ualtinok
force-pushed
the
windows-owner-only
branch
from
October 9, 2026 07:28
5ece3c0 to
27d3799
Compare
A test polling for the PID file could see it empty mid-write and fail to parse it (seen on macOS CI).
ualtinok
force-pushed
the
windows-owner-only
branch
3 times, most recently
from
October 9, 2026 08:13
cf1a677 to
3c46117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows verification run for cortexkit-lease 0.1.2, cortexkit-log 0.3.5 and cortexkit-store 0.2.4: protect_file and create_private_dir set a protected owner-only DACL on Windows, and narrowing an existing directory propagates to files already inside. The Windows-only tests run here, since commons CI covers Windows on pull requests.
Summary by cubic
Enforces owner-only access on Windows for
protect_fileandcreate_private_dir, which previously did nothing and returnedOk.cortexkit-logandcortexkit-storenow use these helpers, andcortexkit-test-supportwrites the daemon PID file atomically so a polling reader never sees it empty.cortexkit-storeno longer treats in-memory databases and SQLite URIs as file paths to protect.Written for commit 3c46117. Summary will update on new commits.