Skip to content

doctor: split provider/model refs on the first slash - #696

Open
xRahul wants to merge 1 commit into
cortexkit:masterfrom
xRahul:fix-doctor-models
Open

xRahul wants to merge 1 commit into
cortexkit:masterfrom
xRahul:fix-doctor-models

Conversation

@xRahul

@xRahul xRahul commented Oct 15, 2026 •

Copy link
Copy Markdown

Refs #697

The hidden-agent catalog check parsed "provider/model" with split("/", 2), so model ids that themselves contain slashes (OpenRouter serves ids like openrouter/free and dots-studio/dots-3-note-preview:free) became a bogus provider/model pair and were wrongly reported as not offered by the host. Split on the first slash only, matching the [provider, ...modelParts] idiom used elsewhere in the repo, and cover both the unknown-model and unknown-variant checks with tests.


Summary by cubic

Fixes the doctor command parsing of provider/model references so model IDs that themselves contain slashes (for example OpenRouter's openrouter/free or dots-studio/dots-3-note-preview:free) are no longer split into bogus provider/model pairs and wrongly reported as not offered by the host.

  • Splits provider and model on the first slash only, matching the [provider, ...modelParts] idiom used elsewhere in the repo.
  • Adds tests covering both the unknown-model and unknown-variant checks with slash-containing model IDs.

Written for commit f571812. Summary will update on new commits.

View guided diff

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Doctor now keeps everything after the first slash when checking configured OpenCode models and variants.

  • OpenCode doctor keeps slashes inside model IDs when checking the host catalog.

Reviews (1) · Last reviewed commit: "doctor: split provider/model refs on the..." · Reviewed by Greptile

The hidden-agent catalog check parsed "provider/model" with
split("/", 2), so model ids that themselves contain slashes (OpenRouter
serves ids like openrouter/free and dots-studio/dots-3-note-preview:free)
became a bogus provider/model pair and were wrongly reported as not
offered by the host. Split on the first slash only, matching the
[provider, ...modelParts] idiom used elsewhere in the repo, and cover
both the unknown-model and unknown-variant checks with tests.
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Waiting for design-approved on #697.

This PR needs a linked issue with the design-approved label before it can be reviewed or merged. Link the approved issue with Approved issue: #<issue> (or Refs #<issue>) in the description. A maintainer will apply the design-approved label on the issue, or trivial on the pull request when there is genuinely no design to agree. The issue stays open until the change ships; maintainers take care of it then.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant