Repository navigation
Conversation
The hidden-agent catalog check parsed "provider/model" with
split("/", 2), so model ids that themselves contain slashes (OpenRouter
serves ids like openrouter/free and dots-studio/dots-3-note-preview:free)
became a bogus provider/model pair and were wrongly reported as not
offered by the host. Split on the first slash only, matching the
[provider, ...modelParts] idiom used elsewhere in the repo, and cover
both the unknown-model and unknown-variant checks with tests.
|
Waiting for This PR needs a linked issue with the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #697
The hidden-agent catalog check parsed "provider/model" with split("/", 2), so model ids that themselves contain slashes (OpenRouter serves ids like openrouter/free and dots-studio/dots-3-note-preview:free) became a bogus provider/model pair and were wrongly reported as not offered by the host. Split on the first slash only, matching the [provider, ...modelParts] idiom used elsewhere in the repo, and cover both the unknown-model and unknown-variant checks with tests.
Summary by cubic
Fixes the doctor command parsing of
provider/modelreferences so model IDs that themselves contain slashes (for example OpenRouter'sopenrouter/freeordots-studio/dots-3-note-preview:free) are no longer split into bogus provider/model pairs and wrongly reported as not offered by the host.[provider, ...modelParts]idiom used elsewhere in the repo.Written for commit f571812. Summary will update on new commits.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Doctor now keeps everything after the first slash when checking configured OpenCode models and variants.
Reviews (1) · Last reviewed commit: "doctor: split provider/model refs on the..." · Reviewed by Greptile