Implement auto-forget in Parquet converter lifecycle - #7752
Open
SungJin1212 wants to merge 2 commits into
Open
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
friedrichg
approved these changes
Aug 9, 2026
Comment on lines
+706
to
+707
| // UnregisterOnShutdown=false lets the instance stay in the ring | ||
| // after stopping, so we can verify auto-forget kicks it out. |
Member
There was a problem hiding this comment.
Suggested change
| // UnregisterOnShutdown=false lets the instance stay in the ring | |
| // after stopping, so we can verify auto-forget kicks it out. |
I think this can be removed.
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement an auto-forget mechanism in the Parquet converter.
Note: This was already defined in the config, but it was a no-op.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags