Repository navigation
Conversation
Integrators keep using quote.buyAmount (after network costs) as a generic toAmount next to other aggregators' before-gas amounts, so CoW ranks last even at an equal price. Add a "Displaying and Comparing Quotes" section, fix the quickstart to build the order from quoteResponse.quote, and link the amount-stage math on the concepts page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
raq0x
marked this pull request as draft
October 8, 2026 21:31
raq0x
marked this pull request as ready for review
October 13, 2026 14:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sellAmount,feeAmount, andbuyAmountfor sell quotes.quoteResponse.quote, signsellAmount + feeAmountwithfeeAmount: "0", apply slippage, handleappData, and submitquoteIdandfrom.Why
Direct API integrators can mistake
quote.buyAmountfor a before-gas output. For sell orders, it already reflects network costs and the applicable protocol fee. Comparing it with another provider’s before-gas output makes CoW look worse even when its net price is better.Ambire recently encountered this (AmbireTech/ambire-common#2779). These changes explain the returned amounts where API integrators first encounter them and show how to compare quotes on the same basis.