Repository navigation
Ignore unmatched exclusions in detailed_match_files - #158
Merged
cpburnz merged 1 commit intoOct 10, 2026
Merged
Conversation
Owner
|
Thanks for finding and fixing this. |
cpburnz
added a commit
that referenced
this pull request
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detailed_match_files()raisesKeyErrorwhen an exclusion matches a file that no previous inclusion added, or when an exclusion is repeated. Remove entries only when present, preserving existing inclusion order and bothall_matchesmodes. Related: #105.Reproduction on current master:
Regression tests cover unmatched exclusions, repeated exclusions, re-inclusion, and removal of an existing match. The unmatched/repeated cases fail on unchanged master. Full unittest discovery passes with the simple and RE2 backends; Hyperscan and the Windows-only case remain untested locally.
Prepared with OpenAI Codex (GPT-6) assistance; the reproduction, tests, and diff were checked before submission.